跳至主要内容

Interesting bug of intellij decompiler

Strange char

When I view the source of a project, I notice it use log4j. So, I click into the logger.error method, and intellij decompile the class file and show the following code:
public void error(Object message, Throwable t) {
    if(!this.repository.isDisabled('鱀')) {//<--here
        if(Level.ERROR.isGreaterOrEqual(this.getEffectiveLevel())) {
            this.forcedLog(FQCN, Level.ERROR, message, t);
        }
    }
}
I was attracted by that strange character, because this character is so rare, so who would use such char in the code? There must be some reason.

Real source

It is strange, right? I am curious about that strange character so I find the source as following:
void error(Object message, Throwable t) {
  if(repository.isDisabled(Level.ERROR_INT))
    return;
  if(Level.ERROR.isGreaterOrEqual(this.getEffectiveLevel()))
    forcedLog(FQCN, Level.ERROR, message, t);
}

// Level.ERROR_INT
public final static int ERROR_INT = 40000;
Now, we understand it. When intellij decompile the class, it convert the int 40000 to a char(which has a range of 0-65535).

Verify

But it may be the java compiler who see it is a int can represented by a char and change it. So I decompile the class file use javap to see whether it is represented by a char or int.
javap -c Category.class
  public void error(java.lang.Object, java.lang.Throwable);
    Code:
       0: aload_0
       1: getfield      #13                 // Field repository:Lorg/apache/log4j/spi/LoggerRepository;
       4: ldc           #31                 // int 40000
       6: invokeinterface #25,  2           // InterfaceMethod org/apache/log4j/spi/LoggerRepository.isDisabled:(I)Z
      11: ifeq          15

// ldc means: push a constant #index from a constant pool (String, int or float) onto the stack
From the line 4, we can see it indeed a int, so it is some kind of bug.

char to int

Actually, when I write a large unicode char in source code, java compiler will automatically change it to a int
  final char c2 = '鱀';
  System.out.println(c2);
  System.out.println('c');

  125: ldc           #19                 // int 40000 -- here
  127: istore        5
  129: getstatic     #5                  // Field java/lang/System.out:Ljava/io/PrintStream;
  132: ldc           #19                 // int 40000 -- and here
  134: invokevirtual #20                 // Method java/io/PrintStream.println:(C)V
  137: getstatic     #5                  // Field java/lang/System.out:Ljava/io/PrintStream;
  140: bipush        99
  142: invokevirtual #20                 // Method java/io/PrintStream.println:(C)V
A simple code snippet can be get from here

Ref

Written with StackEdit.
标签：

评论

发表评论

此博客中的热门博文

Spring Boot: Customize Environment

Spring Boot: Customize Environment Environment variable is a very commonly used feature in daily programming: used in init script used in startup configuration used by logging etc In Spring Boot, all environment variables are a part of properties in Spring context and managed by Environment abstraction. Because Spring Boot can handle the parse of configuration files, when we want to implement a project which uses yml file as a separate config file, we choose the Spring Boot. The following is the problems we met when we implementing the parse of yml file and it is recorded for future reader. Bind to Class Property values can be injected directly into your beans using the @Value annotation, accessed via Spring’s Environment abstraction or bound to structured objects via @ConfigurationProperties. As the document says, there exists three ways to access properties in *.properties or *.yml : @Value : access single value Environment : can access multi
5 条评论
阅读全文

Elasticsearch: Join and SubQuery

Elasticsearch: Join and SubQuery Tony was bothered by the recent change of search engine requirement: they want the functionality of SQL-like join in Elasticsearch! “They are crazy! How can they think like that. Didn’t they understand that Elasticsearch is kind-of NoSQL 1 in which every index should be independent and self-contained? In this way, every index can work independently and scale as they like without considering other indexes, so the performance can boost. Following this design principle, Elasticsearch has little related supports.” Tony thought, after listening their requirements. Leader notice tony’s unwillingness and said, “Maybe it is hard to do, but the requirement is reasonable. We need to search person by his friends, didn’t we? What’s more, the harder to implement, the more you can learn from it, right?” Tony thought leader’s word does make sense so he set out to do the related implementations Application-Side Join “The first implementation
发表评论
阅读全文

Implement isdigit

It is seems very easy to implement c library function isdigit , but for a library code, performance is very important. So we will try to implement it and make it faster. Function So, first we make it right. int isdigit ( char c) { return c >= '0' && c <= '9' ; } Improvements One – Macro When it comes to performance for c code, macro can always be tried. #define isdigit (c) c >= '0' && c <= '9' Two – Table Upper version use two comparison and one logical operation, but we can do better with more space: # define isdigit(c) table[c] This works and faster, but somewhat wasteful. We need only one bit to represent true or false, but we use a int. So what to do? There are many similar functions like isalpha(), isupper ... in c header file, so we can combine them into one int and get result by table[c]&SOME_BIT , which is what source do. Source code of ctype.h : # define _ISbit(bit) (1 << (
发表评论
阅读全文